Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testing checklist to PR template #1118

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Add testing checklist to PR template #1118

merged 1 commit into from
Jan 23, 2024
+26 −4

Conversation

khleomix
Copy link
Contributor

Closes

N/A

What type of PR is this? (put an x to all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Link to test

N/A

Description

  • Add testing checklist to PR template

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 Confluence
  • 🙅 no documentation needed

Others

  • 🦮 Is this issue accessible? (Section 508/WCAG 2.0AA)
  • 🙌 Does this issue pass all the linting? (PHPCS, ESLint, SassLint)

[optional] Are there any post-deployment tasks we need to perform?

@khleomix khleomix self-assigned this Jan 23, 2024
thatmitchcanter
thatmitchcanter approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@thatmitchcanter thatmitchcanter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. I think this covers everything; if not we can add it in when we realize what we're missing. Good to go!~

@thatmitchcanter thatmitchcanter merged commit 756a4a3 into main Jan 23, 2024
3 checks passed
@thatmitchcanter thatmitchcanter deleted the feature/update-pr-template branch January 23, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatmitchcanter thatmitchcanter thatmitchcanter approved these changes

Assignees

@khleomix khleomix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khleomix @thatmitchcanter